This repository was archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
initialize rust logs via ffi #13
Draft
lanzafame
wants to merge
1
commit into
master
Choose a base branch
from
rust-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
package ffiwrapper | ||
|
||
import ( | ||
"os" | ||
|
||
"github.com/filecoin-project/filecoin-ffi/generated" | ||
) | ||
|
||
var logFile *os.File | ||
|
||
func init() { | ||
// get the go-log file via the GO_LOG_FILE env var | ||
logFilePath, exists := os.LookupEnv("GOLOG_FILE") | ||
if !exists { | ||
return | ||
} | ||
// open the file, and get a fd that way | ||
logFile, err := os.OpenFile(logFilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) | ||
if err != nil { | ||
log.Errorw("failed to open log file", "error", err.Error(), "GOLOG_FILE", logFilePaht) | ||
} | ||
// once a fd has been procured, pass it to generated.FilInitLogFd | ||
resp := generated.FilInitLogFd(int32(logFile.Fd())) | ||
resp.Deref() | ||
|
||
//TODO: figure out whether generated.FilDestoryInitLogFdResponse needs to be called | ||
defer generated.FilDestroyInitLogFdResponse(resp) | ||
//TODO: figure out how to close the file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. I haven't thought about a way to stop the logging to file, I expected to run "forever", which probably isn't a good idea. |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
generated.FilDestoryInitLogFdResponse()
should be called, it just destroys the response, not the logging or file handler or so.