Skip to content

Refactor: Cache DataTransferManager and items to share #17384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Reproduce the original issue that caused the NullReferenceException related to WinRT object garbage collection during share operations.
  2. Verify that caching the DataTransferManager instance and the items to share prevents the NullReferenceException.
  3. Ensure that share operations function correctly after the changes.
  4. Run the application with the fix and monitor for any new exceptions or crashes related to share operations.
  5. Test share operations with different file types and sizes.
  6. Test share operations from different locations within the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants