-
Notifications
You must be signed in to change notification settings - Fork 149
fix: misleading endpoint status codes and error messages #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e-ts-refactor-redone
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
…om/jescalada/git-proxy into 1150-vitest-migration-from-service
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (73.39%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 83.35% 81.02% -2.34%
==========================================
Files 70 65 -5
Lines 3004 4532 +1528
Branches 499 775 +276
==========================================
+ Hits 2504 3672 +1168
- Misses 397 845 +448
+ Partials 103 15 -88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I double-checked that the frontend status code handlers are still working. Since we removed a bunch of false 401 errors, most of these would get caught by the generic handler instead. Of course, we should make these more descriptive by showing the actual error message and status code and removing the callback-based error handling entirely. This is captured in #1188 |
Fixes #1285. Based on #1202, would love to get that one merged first!