Skip to content

Log platform if binary not found #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaibolay merged 4 commits into from
Nov 30, 2024
Merged

Log platform if binary not found #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d898c3a
Log platform if binary not found
kaibolay Nov 29, 2024
f00fd83
fix test
kaibolay Nov 29, 2024
97c06da
disambiguate error message
kaibolay Nov 30, 2024
6aca815
further clarify error message
kaibolay Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def self.run(params)
timeout = get_upload_timeout(params)

binary_path = get_binary_path(platform, params)
UI.user_error!("Couldn't find binary.") if binary_path.nil?
UI.user_error!("Couldn't find binary at path #{binary_path}.") unless File.exist?(binary_path)
UI.user_error!("Couldn't determine path for #{platform} binary.") if binary_path.nil?
UI.user_error!("Couldn't find #{platform} binary at path #{binary_path}.") unless File.exist?(binary_path)
binary_type = binary_type_from_path(binary_path)

# TODO(lkellogg): This sets the send timeout for all POST requests made by the client, but
Expand Down
6 changes: 3 additions & 3 deletions spec/firebase_app_distribution_action_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,16 +226,16 @@
allow(action).to receive(:get_authorization).and_return(double('authorization', access_token: 'access-token'))
end

it 'raises error if it cannot find a valid binary path' do
it 'raises error if it cannot determine a valid binary path' do
expect do
action.run(params.merge(ipa_path: nil))
end.to raise_error("Couldn't find binary.")
end.to raise_error("Couldn't determine path for ios binary.")
end

it 'raises error if binary does not exist' do
expect do
action.run(params)
end.to raise_error("Couldn't find binary at path debug.ipa.")
end.to raise_error("Couldn't find ios binary at path debug.ipa.")
end

describe 'with android app' do
Expand Down