fix: rename v1 Event to LegacyEvent to avoid api-extractor conflict

[taeold]

Unsure exactly what caused the change, but Event type in src/v1/cloud-functions.ts is not generating reference doc with odd suffix Event_v2.

This seems to be a known issue per microsoft/rushstack#3581.

I'm making a breaking change to rename the type to LegacyEvent instead. This type is public, but I don't inspect wide usage since it represent internal state of the function triggers.

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a documentation generation issue by renaming the Event interface to LegacyEvent within the v1 module of firebase-functions, specifically to resolve an api-extractor conflict. While this is a breaking change, its impact is expected to be minimal due to the internal nature of the type. Additionally, the PR introduces comprehensive documentation for testing native ESM support across different JavaScript module environments and updates the CI/CD pipeline to include a build step for Node.js 22.

Highlights

• Type Renaming for API Extractor: The Event interface in src/v1/cloud-functions.ts has been renamed to LegacyEvent to resolve a conflict with api-extractor that was causing incorrect documentation generation.
• ESM Support Bug Bash Documentation: A new markdown file, ESM_BUGBASH.md, has been added, detailing extensive testing scenarios for native ESM support in firebase-functions, covering various user configurations (pure ESM, CommonJS, TypeScript with NodeNext, and dual-loading).
• Cloud Build Update: A new cloudbuild.test.yaml file introduces a Cloud Build step to ensure compatibility and build processes with Node.js version 22.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a naming conflict with api-extractor by renaming the v1 Event interface to LegacyEvent. This is a breaking change, as noted in the description. The renaming has been applied consistently across all relevant files. The change is straightforward and well-executed. I've added one minor suggestion to improve code clarity by removing a redundant type union.

[egilmorez]

"LegacyName" SGTM, thanks!