Skip to content

Conversation

@mbleigh
Copy link
Contributor

@mbleigh mbleigh commented Oct 5, 2021

No description provided.

@mbleigh mbleigh requested a review from egilmorez October 5, 2021 17:19
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@egilmorez
Copy link
Contributor

egilmorez commented Oct 7, 2021

As we noted in offline discussions:

  1. To make the v1 TOC work as usual, we'd need to change back the v2-ish values in https://github.com/firebase/firebase-functions/blob/master/docgen/theme/layouts/default.hbs

  2. Filenames linked from index.html generated with this PR don't match the actual HTML filenames. I think/hope that could be fixed in the script, but am not sure exactly how.

Values for 1) would be:

<meta name="book_path" value="/docs/reference/_book.yaml">
<meta name="gtm_var" data-key="docType" data-value="reference">

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants