-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Auth] TOTP support for macOS #15112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
0f089fe
to
6b28775
Compare
Thanks for the PR, @cbenhagen! Please fix the style check: https://github.com/firebase/firebase-ios-sdk/actions/runs/16248298480/job/45968757691?pr=15112 See https://github.com/firebase/firebase-ios-sdk?tab=readme-ov-file#code-formatting for the prereqs for running the |
6b28775
to
fcf2fda
Compare
@ncooke3 sorry for the oversight! Updated my branch. |
f299b7f
to
29757c1
Compare
I also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbenhagen, were you able to do an E2E test of this feature?
@ncooke3, yes I tested this with our Flutter app and am able to enroll & unenroll as well as login with the TOTP factor. |
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Thanks again, @cbenhagen! |
This PR adds support for TOTP on macOS.
Partially fixes #10034