Skip to content

Conversation

@aalej
Copy link
Contributor

@aalej aalej commented Dec 16, 2025

Description

Add validation when prompting which apps to add DataConnect SDK. Ideally, the scenario if (!pickedApps || !pickedApps.length) will never happen, but in the unlikely chance it does, it would be a good idea to keep it and throw an error

Scenarios Tested

=== Dataconnect Setup
i  dataconnect: ensuring required API firebasedataconnect.googleapis.com is enabled...
i  dataconnect: ensuring required API sqladmin.googleapis.com is enabled...
✔ Your project already has existing services. Which would you like to set up local files for? us-central1/test-dc-2
⚠  dataconnect: CloudSQL no cost trial has already been used on this project.
✔  dataconnect: Detected existing apps web-app-2 (web), web-app (web)
? Which apps do you want to set up Data Connect SDKs in? (Press <space> to select, <a> to toggle all, <i> to invert selection, and <enter> to proceed)
❯◯ web-app-2 (web)
 ◯ web-app (web)
> Please choose at least one app.

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aalej, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial validation mechanism within the DataConnect SDK setup flow. It specifically addresses the scenario where a user might attempt to proceed without selecting any applications, by adding a prompt-level validation that requires at least one app to be chosen. This enhancement improves the robustness and user-friendliness of the setup process, preventing potential errors downstream.

Highlights

  • DataConnect SDK Setup Validation: Added a validation step to the DataConnect SDK app setup process, ensuring that users select at least one application before proceeding.
  • Improved User Experience: The interactive prompt for selecting apps now includes a real-time validation message if no apps are chosen, guiding the user to make a selection.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces client-side validation to a checkbox prompt in src/init/features/dataconnect/sdk.ts. A validate function has been added to the checkbox configuration to ensure that users select at least one app, returning an error message if no choices are made. There are no review comments provided for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant