Skip to content

fix: Fix analyzer infos #17584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Jul 31, 2025

Description

This just fixes a number of analyzer info messages so that there aren't any in the repo. It cleans up the "Problems" view in VSCode, and actually could avoid some coding issues.

I looked at the CI, and it appears to already use dart analyze --fatal-infos, so I'm not sure why these were missed. Maybe because they haven't been modified since that was turned on?

There should be no change in functionality because of any of these changes, although the added awaits could cause a change in execution order.

Related Issues

No issues found for this.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gspencergoog gspencergoog changed the title Fix analyzer warnings/infos Fix analyzer infos Jul 31, 2025
@gspencergoog gspencergoog changed the title Fix analyzer infos fix: Fix analyzer infos Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant