-
Notifications
You must be signed in to change notification settings - Fork 631
feat(py): Implemented deepseek plugin #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @zarinn3pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a new Python plugin for integrating DeepSeek models into the Genkit ecosystem. The implementation meticulously mirrors the existing JavaScript plugin, ensuring a consistent developer experience and feature set. By utilizing Genkit's OpenAI-compatible model infrastructure, the plugin efficiently wraps DeepSeek's API, providing capabilities such as multi-turn conversations, tool calling, streaming responses, and configurable model parameters. The inclusion of comprehensive tests and a practical sample application facilitates quick adoption and validation of the new integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Deepseek plugin for Python, complete with tests and a sample application. The implementation is comprehensive and follows the provided plan for the most part. I've identified a few areas for improvement, primarily focusing on fixing a bug in the plugin initialization, correcting some type hints and docstrings for clarity, and improving the sample application to better demonstrate streaming and multi-turn chat functionalities. These changes will enhance the plugin's correctness and usability.
47a8651 to
3989589
Compare
yesudeep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the comments added by Gemini Code Assist.
|
@zarinn3pal I can not run the sample successfully on my end. I shared the error message with you via chat. On top of that, please refer to model plugin in JS SDK to have the same model Config and Tool in the picture I shared with you. |
|
@zarinn3pal please also add run.sh file to be consistent with other sample flows. |
3d0adc2 to
cc48625
Compare
cc48625 to
e25de2f
Compare
Implemented Deepseek plugin with tests and samples