Going off winter-2020, removed div's from show and index. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ca84ba.
Remove rendering JSON tabfix Additional fixes Remove fallbacks All should be as it's supposed to Add spaces around notice Add spacing around notices, redirect to show page with failure alert
rename _bootstrapcdn_assets to _cdn_assets blacklist default rails routes update layout.html.erb with rails 6 helpers Update cdn resources Only allow GET routes in navbar
Putting all of the draft:account actions into one controller, ____AuthenticationController (I believe that this is the pattern Devise follows?); to make it easier to see in one place and understand, and skip the :force____sign_in before_action for signing up/in a person opts in to that. I believe the older approach grew organically out of adding authentication to an existing tutorial project while I was recording a video (photogram-gui => photogram-signin) and then we codified it in this gem. I also replace `session.fetch()` with `session[]` temporarily because Rails has added `fetch` itself; our monkeypatch now has different behavior than the canonical method. After this quarter, we'll go back to `.fetch`. In preparation for that, I replace `ActiveRecord::Relation#at(0)` with `.first` so that the gem will ultimately be able to be used without our monkeypatches.
variables were changed to be more current with our current teachings in class. The singluar variables were moved to @the_ and the plural were changed to @list_of. We used the gem indefinite_article which helped with the naming of the block variables in the index page. This gem needed to be initalized in three different places. wip added indefintite_article gem wip wip wip wip wip wip wip Require gem in resource_generator.rb update gemspec removed require from resource generator wip" " added indefinitize to all remaining block variables added one more @the_ to the create action added @the_ to update action added @the_ to the redirect in update forgot a _ removed require from resource_generator.rb needs to have require 'indefinite_article' in the resource generator.rb file removed git_source from the gemfile removed a space from gemfile changed the single quotes to double and removed the extra space at the beginning of the index file
the instance variables from the draft:resource controller. I replaced these with regular variables because they were not being brought to a html page. This resovles issues #93.
in the summer 2020 quarter. This resolves #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, edited wording talking about force_sign_in