Disambiguating by breaking more conventions #3

raghubetina · 2017-05-20T13:43:47Z

Removing all instance variables to decouple variable name choices
between actions that re-use templates, and to remove the additional
cognitive load of learning what an instance variable is. Also,
avoiding state is better practice anyway, IMO.
Using strings as keys to the params hash following the heuristic:
"If we could change it to 'zebra' on a whim, then use a string;
otherwise use a symbol."
Making variable and input names longer and more pedantic.

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/read_only_controller.rb

+    <%= singular_table_name %>_to_show = <%= class_name.singularize %>.find(params[:id_to_display])
+
+    render("<%= plural_table_name.underscore %>_templates/show.html.erb", :locals => {
+      :the_<%= singular_table_name.underscore %> => <%= singular_table_name %>_to_show


unexpected token tLT
unterminated string meets end of file

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/read_only_controller.rb


  def show
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id])
+    <%= singular_table_name %>_to_show = <%= class_name.singularize %>.find(params[:id_to_display])


unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/read_only_controller.rb

 class <%= plural_table_name.camelize %>Controller < ApplicationController
  def index
-    @<%= plural_table_name.underscore %> = <%= class_name.singularize %>.all
+    all_<%= plural_table_name.underscore %> = <%= class_name.singularize %>.all.order(:created_at => :desc)


unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/controller.rb

-    @remaining_count = <%= class_name.singularize %>.count
-
-    render("<%= plural_table_name.underscore %>_templates/destroy_row.html.erb")
+    render("<%= singular_table_name.underscore %>_templates/destroy_row.html.erb", :locals => {


unexpected token tIDENTIFIER
unterminated string meets end of file

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/controller.rb


 <% unless skip_validation_alerts? -%>
-    redirect_to("/<%= @plural_table_name.underscore %>", :notice => "<%= singular_table_name.humanize %> deleted successfully.")
+    redirect_to("/<%= plural_table_name.underscore %>", :notice => "<%= singular_table_name.humanize %> deleted successfully.")


unexpected token tIDENTIFIER
unexpected token tRPAREN

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/controller.rb


    if save_status == true
-      redirect_to("/<%= @plural_table_name.underscore %>/#{@<%= singular_table_name.underscore %>.id}", :notice => "<%= singular_table_name.humanize %> updated successfully.")
+      redirect_to("/<%= plural_table_name.underscore %>/#{<%= singular_table_name.underscore %>_to_change.id}", :notice => "<%= singular_table_name.humanize %> updated successfully.")


unexpected token tLT
unexpected token tRPAREN

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/controller.rb


 <% attributes.each do |attribute| -%>
-    @<%= singular_table_name.underscore %>.<%= attribute.column_name %> = params[:<%= attribute.column_name %>]
+    <%= singular_table_name.underscore %>_to_change.<%= attribute.column_name %> = params["form_<%= attribute.column_name %>"]


unexpected token tIDENTIFIER
unexpected token tOP_ASGN

houndci-bot · 2017-05-20T13:43:56Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def update_row
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id_to_modify])
+    <%= singular_table_name.underscore %>_to_change = <%= class_name.singularize %>.find(params["id_to_modify"])


unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T13:43:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


-    render("<%= plural_table_name.underscore %>_templates/edit_form.html.erb")
+    render("<%= singular_table_name.underscore %>_templates/edit_form.html.erb", :locals => {
+      :<%= singular_table_name.underscore %>_to_prefill => existing_<%= singular_table_name.underscore %>


unexpected token tOP_ASGN
unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T13:43:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def edit_form
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:prefill_with_id])
+    existing_<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params["prefill_with_id"])


unexpected token tIDENTIFIER

- Removing all instance variables to decouple variable name choices between actions that re-use templates, and to remove the additional cognitive load of learning what an instance variable is. Also, avoiding state is better practice anyway, IMO. - Using strings as keys to the `params` hash following the heuristic: "If we could change it to 'zebra' on a whim, then use a string; otherwise use a symbol." - Making variable and input names longer and more pedantic.

houndci-bot · 2017-05-20T15:05:56Z

lib/generators/draft/resource/templates/controllers/controller.rb

-    @remaining_count = <%= class_name.singularize %>.count
-
-    render("<%= plural_table_name.underscore %>_templates/destroy_row.html.erb")
+    render("<%= singular_table_name %>_templates/destroy_row.html.erb", :locals => {


unexpected token tIDENTIFIER
unterminated string meets end of file

houndci-bot · 2017-05-20T15:05:56Z

lib/generators/draft/resource/templates/controllers/controller.rb


 <% unless skip_validation_alerts? -%>
-    redirect_to("/<%= @plural_table_name.underscore %>", :notice => "<%= singular_table_name.humanize %> deleted successfully.")
+    redirect_to("/<%= plural_table_name %>", :notice => "<%= singular_table_name.humanize %> deleted successfully.")


unexpected token tIDENTIFIER
unexpected token tRPAREN

houndci-bot · 2017-05-20T15:05:56Z

lib/generators/draft/resource/templates/controllers/controller.rb

+    <%= singular_table_name %>_to_delete = <%= class_name.singularize %>.find(params["id_to_remove"])

-    @<%= singular_table_name.underscore %>.destroy
+    <%= singular_table_name %>_to_delete.destroy


unexpected token tLT

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def destroy_row
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id_to_remove])
+    <%= singular_table_name %>_to_delete = <%= class_name.singularize %>.find(params["id_to_remove"])


unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb

+    redirect_to("/<%= plural_table_name %>/#{<%= singular_table_name %>_to_change.id}")
 <% else -%>
-    render("<%= plural_table_name.underscore %>_templates/update_row.html.erb")
+    render("<%= singular_table_name %>_templates/update_row.html.erb", :locals => {


unexpected token tIDENTIFIER
unexpected token tLCURLY

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


    if save_status == true
-      redirect_to("/<%= @plural_table_name.underscore %>/#{@<%= singular_table_name.underscore %>.id}", :notice => "<%= singular_table_name.humanize %> updated successfully.")
+      redirect_to("/<%= plural_table_name %>/#{<%= singular_table_name %>_to_change.id}", :notice => "<%= singular_table_name.humanize %> updated successfully.")


unexpected token tLT
unexpected token tRPAREN

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


 <% attributes.each do |attribute| -%>
-    @<%= singular_table_name.underscore %>.<%= attribute.column_name %> = params[:<%= attribute.column_name %>]
+    <%= singular_table_name %>_to_change.<%= attribute.column_name %> = params["<%= attribute.column_name %>_from_form"]


unexpected token tIDENTIFIER
unexpected token tOP_ASGN

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def update_row
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id_to_modify])
+    <%= singular_table_name %>_to_change = <%= class_name.singularize %>.find(params["id_to_modify"])


unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


-    render("<%= plural_table_name.underscore %>_templates/edit_form.html.erb")
+    render("<%= singular_table_name %>_templates/edit_form.html.erb", :locals => {
+      :<%= singular_table_name %>_to_prefill => existing_<%= singular_table_name %>


unexpected token tOP_ASGN
unexpected token tIDENTIFIER

houndci-bot · 2017-05-20T15:05:57Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def edit_form
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:prefill_with_id])
+    existing_<%= singular_table_name %> = <%= class_name.singularize %>.find(params["prefill_with_id"])


unexpected token tIDENTIFIER

houndci-bot · 2017-11-08T03:40:55Z

lib/generators/draft/resource/templates/controllers/read_only_controller.rb

-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id])
+    id_of_<%= singular_table_name %>_to_show = params.fetch("id_to_display")
+
+    @<%= singular_table_name %>_to_show = <%= class_name.singularize %>.find(id_of_<%= singular_table_name %>_to_show)


unexpected @'

houndci-bot · 2017-11-08T03:40:55Z

lib/generators/draft/resource/templates/controllers/read_only_controller.rb


  def show
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id])
+    id_of_<%= singular_table_name %>_to_show = params.fetch("id_to_display")


unexpected token tIDENTIFIER

houndci-bot · 2017-11-08T03:40:55Z

lib/generators/draft/resource/templates/controllers/controller.rb

+    id_of_<%= singular_table_name %>_to_show = params.fetch("id_to_display")

-    render("<%= plural_table_name.underscore %>_templates/show.html.erb")
+    @<%= singular_table_name %>_to_show = <%= class_name.singularize %>.find(id_of_<%= singular_table_name %>_to_show)


unexpected @'

houndci-bot · 2017-11-08T03:40:55Z

lib/generators/draft/resource/templates/controllers/controller.rb


  def show
-    @<%= singular_table_name.underscore %> = <%= class_name.singularize %>.find(params[:id_to_display])
+    id_of_<%= singular_table_name %>_to_show = params.fetch("id_to_display")


unexpected token tIDENTIFIER

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/templates/controllers/controller.rb

 class <%= plural_table_name.camelize %>Controller < ApplicationController
  def index
-    @<%= plural_table_name.underscore %> = <%= class_name.singularize %>.all
+    @list_of_<%= plural_table_name %> = <%= class_name.singularize %>.all.order({ :created_at => :desc })


unexpected token tIDENTIFIER

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/resource_generator.rb

        %w(index show new_form create_row edit_form update_row destroy_row)
      else
-        %w(index new_form edit_form show)
+        %w(index show new_form new_form_with_errors edit_form edit_form_with_errors)


Line is too long. [84/80]

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/resource_generator.rb


-      template "specs/crud_spec.rb", "spec/features/crud_#{plural_table_name.underscore}_spec.rb"
-      template "specs/factories.rb", "spec/factories/#{plural_table_name.underscore}.rb"
+      template "specs/crud_spec.rb", "spec/features/crud_#{plural_table_name}_spec.rb"


Line is too long. [86/80]

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/resource_generator.rb

      available_views.each do |view|
        filename = view_filename_with_extensions(view)
-        template filename, File.join("app/views", "#{plural_table_name}_templates", File.basename(filename))
+        template filename, File.join("app/views", "#{singular_table_name}_templates", File.basename(filename))


Line is too long. [110/80]

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/resource_generator.rb

+        template "controllers/read_only_controller.rb", "app/controllers/#{plural_table_name}_controller.rb"
      else
-        template "controllers/controller.rb", "app/controllers/#{plural_table_name.underscore}_controller.rb"
+        template "controllers/controller.rb", "app/controllers/#{plural_table_name}_controller.rb"


Line is too long. [98/80]

houndci-bot · 2017-11-08T03:40:56Z

lib/generators/draft/resource/resource_generator.rb


      if read_only?
-        template "controllers/read_only_controller.rb", "app/controllers/#{plural_table_name.underscore}_controller.rb"
+        template "controllers/read_only_controller.rb", "app/controllers/#{plural_table_name}_controller.rb"


Line is too long. [108/80]

* Add github login * #3 - Fixed failing test * #3 - Fixed other test cases * #3 - Minor changes * #3 - Indentation fixes * #3 Added .rubocop.yml and fixed rubocop issues * #3 - Test cases for https://github.com/firstdraft/ideas/pull/3 * #3 - CicleCi add minitest_globs and fixed rubocop issues * #3 - Added bootswatch paper theme * #3 - Turn off hound ci for js, css * we do not recommend using capybara * added database yml to gitignore * added database yml sample file for postgresqlapp * #3 - Removed rspec completely * #3 - Remove Factory Girl and instead uses fixtures * #3 - Updated CircleCi.yml and modified setup script * #3 - Added database.yml.ci * #3 - Review comments changes

houndci-bot reviewed May 20, 2017

View reviewed changes

raghubetina force-pushed the disambiguating branch from 22711f0 to e594291 Compare May 20, 2017 14:53

raghubetina force-pushed the disambiguating branch from e594291 to eebc1c7 Compare May 20, 2017 14:54

Add new_form_with_errors

e8b006c

houndci-bot reviewed May 20, 2017

View reviewed changes

raghubetina added 10 commits May 20, 2017 11:10

Simplify alerts

210d1c3

Put back rails info link

251fa4b

Alerts in containers

3d9b939

Remove rails info link

ee12f24

Better copy on Devise edit registration link

05abf80

Re-ivar index

01dcecb

De-ivar show

9a205e3

De-ivar new/create

5fb7865

Prepare new and edit for partializing

ecd241a

De-ivar destroy

0515e84

houndci-bot reviewed Nov 8, 2017

View reviewed changes

raghubetina added 4 commits November 7, 2017 21:45

Cleanup

2a6a104

FactoryGirl => FactoryBot

2b2e0ca

Bug

33ffdcf

bug

a885da0

Disambiguating by breaking more conventions #3

Are you sure you want to change the base?

Disambiguating by breaking more conventions #3

Uh oh!

Conversation

raghubetina commented May 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants