Skip to content

Conversation

@jelaniwoods
Copy link
Contributor

@jelaniwoods jelaniwoods commented Aug 4, 2025

There were problems using Zeitwerk. This commit removes it to simplify usage.


Important

Remove Zeitwerk and update version to 0.2.2, simplifying code with explicit requires and removing the Zeitwerk dependency.

  • Behavior:
    • Remove Zeitwerk setup from lib/rspec/html_messages.rb and replace with explicit require statements for value_formatter, diff_formatter, and template_renderer.
  • Dependencies:
    • Remove zeitwerk dependency from rspec-html_messages.gemspec.
  • Version:
    • Update version to 0.2.2 in lib/rspec/html_messages/version.rb.

This description was created by Ellipsis for fa11af0. You can customize this summary. It will automatically update as commits are pushed.

@jelaniwoods jelaniwoods merged commit 9f12f4b into main Aug 4, 2025
3 checks passed
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to fa11af0 in 1 minute and 28 seconds. Click for details.
  • Reviewed 45 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. lib/rspec/html_messages.rb:3
  • Draft comment:
    Removed Zeitwerk loading block and replaced it with explicit requires. Make sure to update requires when adding new modules.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 30% <= threshold 50% The comment is informative, explaining what was changed and giving a suggestion for future actions. It doesn't ask for confirmation or suggest a specific code change. It doesn't violate any rules directly, but it doesn't provide actionable feedback either.
2. lib/rspec/html_messages/version.rb:5
  • Draft comment:
    Version bump to 0.2.2 is appropriate for this change.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version bump is appropriate, which is not within the scope of useful comments as per the rules.
3. rspec-html_messages.gemspec:28
  • Draft comment:
    Removed Zeitwerk dependency from gemspec as it’s no longer used; ensure explicit requires cover all needed files.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_RGmjVeIYD3hzlFO4

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants