feat: view variables & namespaced query parameters #2620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adityathebe
force-pushed
the
feat/view-variables
branch
from
9a457a9 to
3606370
Compare
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adityathebe
force-pushed
the
feat/view-variables
branch
from
8a5660a to
ff9a0a5
Compare
adityathebe
force-pushed
the
feat/view-variables
branch
from
ff9a0a5 to
f1a6577
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
adityathebe
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for view variables and namespaced query parameters to enable multiple tables on the same page without URL parameter conflicts. The implementation separates global view-level filters from table-specific column filters using URL parameter prefixing.
- Introduces view variables as global filters that affect entire views (panels + tables)
- Implements namespaced query parameters using prefixes to prevent conflicts between multiple tables
- Separates form handling for global filters vs table column filters
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/views/components/SingleView.tsx | Updates view data fetching to include variables and implements prefixed search params |
| src/pages/audit-report/types/index.ts | Adds ViewVariable type definition and requestFingerprint to ViewResult |
| src/pages/audit-report/components/View/ViewTableFilterForm.tsx | New component for table-specific filter form with prefixed parameters |
| src/pages/audit-report/components/View/View.tsx | Refactors to separate global and table filters, adds variable support |
| src/pages/audit-report/components/View/GlobalFiltersForm.tsx | New component for managing global view-level filter parameters |
| src/pages/audit-report/components/View/GlobalFilters.tsx | New component rendering global filter UI controls |
| src/pages/audit-report/components/DynamicDataTable.tsx | Adds tablePrefix support for prefixed parameter keys in cell filters |
| src/hooks/usePrefixedSearchParams.ts | New hook for managing URL search params with prefixes |
| src/api/services/views.ts | Updates API calls to support variables and request fingerprinting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for