feat: permission form tags #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Role tab as fourth option in permission form subject controls alongside Team, Person, and Notification. Role selection maps to subject field with subject_type set to "group" and supports admin, editor, viewer, responder, and commander roles.
Add playbook as a new subject type option in PermissionSubjectControls: - Import FormikPlaybooksDropdown component - Add "Playbook" to switch options and type union - Handle playbook selection in state initialization and effects - Set subject_type to "playbook" when playbook is selected - Store selected playbook ID in subject field
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the permissions system by adding tags support, expanding subject types to include roles and playbooks, and improving the refresh functionality. The changes enable more granular permission control through tags and broader subject coverage.
- Add tags support for permissions with key-value mapping
- Expand subject types to include roles and playbooks
- Replace query client refresh with ref-based refetch mechanism
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Settings/PermissionsPage.tsx | Switch from useQueryClient to ref-based refetch pattern |
| src/components/Permissions/PermissionsView.tsx | Add onRefetch prop and playbook:* action option |
| src/components/Permissions/PermissionsTable.tsx | Refactor RLS badge rendering from subject column to resource column with individual tag/agent badges |
| src/components/Permissions/ManagePermissions/Forms/PermissionSubjectControls.tsx | Add Role and Playbook subject types with new dropdown components |
| src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx | Add tags field with FormikKeyValueMapField |
| src/components/Forms/Formik/FormikRoleDropdown.tsx | New dropdown component for role selection |
| src/api/types/permissions.ts | Update type definitions with new subject types and tags field |
| src/api/services/users.ts | Filter out system users and deleted users from person queries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Remove RLS payload (tags/agents) from Subject column - Add individual badges for each tag and agent in Resource column - Display tags as "key: value" badges in blue - Display agents as "agent: name" badges in gray - Use inline layout for compact display alongside resource info
adityathebe
force-pushed
the
feat/permission-form-tags
branch
from
2327939 to
cd80d0e
Compare
|
* Move subject to the top
- Action dropdown now hidden until resource is selected - Playbook resources show playbook-specific actions (run, approve, *) - Other resources (catalog, component, connection, canary, global) show common actions only
… and playbooks Unifies resource selection by using FormikResourceSelectorDropdown for both connection and playbook resources instead of their dedicated components, providing consistent filtering and search functionality across all resource types.
adityathebe
force-pushed
the
feat/permission-form-tags
branch
from
7c480cb to
800b094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2634