fix: permission form #2638
Merged
fix: permission form #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes permission table refresh issues and adds support for CRD-sourced permissions. The changes ensure the permissions table updates immediately after CRUD operations and properly handles read-only CRD permissions.
- Fixed permission table refresh by adding query invalidation to create, update, and delete operations
- Added CRD permission support with read-only form behavior and visual indicators
- Improved UI by reordering subject selector options and renaming types for clarity
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Permissions/PermissionsView.tsx | Updated type reference from PermissionAPIResponse to PermissionsSummary |
| src/components/Permissions/PermissionsTable.tsx | Added CRD source indicator and updated type references |
| src/components/Permissions/ManagePermissions/Forms/PermissionSubjectControls.tsx | Reordered subject options to show "Person" first |
| src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx | Added query invalidation for table refresh and CRD read-only support |
| src/components/Permissions/ManagePermissions/Forms/DeletePermission.tsx | Added query invalidation to refresh table after deletion |
| src/api/types/permissions.ts | Renamed PermissionAPIResponse to PermissionsSummary and added source field |
| src/api/services/permissions.ts | Updated type reference to use PermissionsSummary |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PermissionAPIResponsetype toPermissionsSummaryfor better code clarity