feat: access scopes #2645
feat: access scopes #2645
Conversation
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive access scopes feature that allows users to define visibility boundaries for resources. The implementation includes a new page for managing access scopes, form components for creating/editing scopes, and supporting infrastructure.
- Adds complete access scopes management with CRUD operations
- Implements both form-based and YAML-based scope configuration
- Removes unnecessary tags and agents filtering from permissions forms (likely moved to access scopes)
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Settings/PermissionsPage.tsx | Adds informational banner linking to access scopes |
| src/pages/Settings/AccessScopesPage.tsx | New main page for access scopes management |
| src/context/UserAccessContext/permissions.ts | Adds access_scopes table reference |
| src/components/Settings/ResourceTable.tsx | Adds access_scopes to table configuration |
| src/components/SchemaResourcePage/resourceTypes.tsx | Adds access_scopes to resource type definitions |
| src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx | Removes tags and agents filtering functionality |
| src/components/Forms/Formik/FormikSelectDropdown.tsx | Adds SSR safety check for document.body |
| src/components/AccessScopes/* | New components for access scopes management |
| src/api/types/accessScopes.ts | Type definitions for access scopes |
| src/api/services/accessScopes.ts | API service functions |
| src/api/query-hooks/useAccessScopesQuery.ts | React Query hooks |
| src/App.tsx | Adds routing and navigation for access scopes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adityathebe
force-pushed
the
feat/access-scopes
branch
from
a48da11 to
057dcd1
Compare
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adityathebe
force-pushed
the
feat/access-scopes
branch
from
057dcd1 to
975a089
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adityathebe
force-pushed
the
feat/access-scopes
branch
from
4d2a826 to
2f15e49
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adityathebe
force-pushed
the
feat/access-scopes
branch
from
677c817 to
b4525b3
Compare
The creator avatar wasn't rendering because the created_by field was never set when saving access scopes. This fix ensures: - created_by is set when creating new access scopes - updated_by is set when updating access scopes - API queries properly fetch created_by with avatar info using the standard AVATAR_INFO pattern - Type definitions include created_by and updated_by fields
Show validation errors when submitting the form with no scopes or empty scope fields. Errors appear inline on the top right of each scope header.
…scopes - Add live preview showing parsed names as badges - Validate wildcard usage interactively (must be alone) - Improve hint text clarity for names field - Increase names textarea to 6 rows - Remove scope number headers for cleaner UI
adityathebe
force-pushed
the
feat/access-scopes
branch
from
b4525b3 to
fbd86b9
Compare
2 participants
No description provided.