feat: permission form updates #2648
Merged
+81
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Join with people table to fetch created_by user info - Display avatar in Created By column - Handle missing creator gracefully
- Add read-only banner when source is KubernetesCRD - Disable all form fields with pointer-events-none and opacity - Add disabled prop to PermissionSubjectControls - Display linked CRD in footer via CanEditResource - Only show delete button for UI-created permissions
- Remove tags and agents from PermissionTable type - Remove tags and agents from PermissionsSummary type - Remove badge rendering logic from permissions table - Simplify Resource column display
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes tags and agents functionality from the permissions system as they are no longer needed. It also improves the permission form UI with better read-only state handling and fixes the created_by field access.
- Removed tags and agents support from permissions table display and type definitions
- Enhanced permission form with read-only state indicators and improved UI styling
- Fixed created_by field access in API calls and table display
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| PermissionsTable.tsx | Removed tags/agents display logic and badge rendering, fixed created_by field access |
| PermissionSubjectControls.tsx | Added disabled prop support to prevent form interaction when read-only |
| PermissionForm.tsx | Enhanced UI with read-only warnings and improved layout styling |
| permissions.ts | Updated type definitions to remove tags/agents fields and fix created_by field |
| permissions.ts (services) | Updated API call to properly select created_by field with avatar info |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adityathebe
force-pushed
the
feat/revamp-permission-form
branch
from
672e906 to
6f2f478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.