fix: teams add button permissions #2651
Merged
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes permissions for the teams "add" button by adding teams table permissions and adjusting UI styling for better layout management.
- Added teams table to the permissions configuration
- Removed overflow-y-auto styling from container divs to fix layout issues
- Added className prop for button alignment styling
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/context/UserAccessContext/permissions.ts | Added "teams" table to the permissions tables configuration |
| src/components/SchemaResourcePage/SchemaResourceEdit.tsx | Updated CSS classes to remove overflow styling and add button alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add missing teams entry to permissions table to fix Add button not showing on Teams page due to authorization check failure.
Fix Delete and Update buttons being cut off with excessive white space in schema resource edit forms (Teams, Rules, etc) by: - Removing overflow-y-auto from parent container to prevent full page scroll - Changing form from flex-1 to h-full to prevent expansion - Overriding CanEditResource className to remove flex-1 expansion
adityathebe
force-pushed
the
fix/teams-add-button-permissions
branch
from
5aea078 to
27ad87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.