fix: resolve TypeScript errors in test files #2654
Merged
+52
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add missing isViewer property to UserAccessState mocks - Add required properties to CategorizedPlaybookRunAction test mocks - Add missing actions array to Playbook spec - Add missing name property to PlaybookAction
adityathebe
force-pushed
the
fix/test-type-errors
branch
from
f2e7c03 to
9929c24
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR resolves TypeScript compilation errors in test files by adding missing required properties to mock objects. The changes ensure that all test mocks conform to the expected TypeScript interfaces, allowing the codebase to pass type checking.
Key Changes
- Added missing required properties to test mocks across multiple test files
- Added
isViewerproperty to UserAccessState mocks - Added required properties (
id,name,status,playbook_run_id,start_time) to CategorizedPlaybookRunAction mocks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PlaybookSpecCard.unit.test.tsx | Added missing name property to PlaybookAction mock |
| SubmitPlaybookRunForm.unit.test.tsx | Added missing actions array to Playbook spec mock |
| PlaybooksActionsResults.unit.test.tsx | Added required properties to CategorizedPlaybookRunAction mocks |
| CheckRunNow.unit.test.tsx | Added missing isViewer property to UserAccessState mocks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isViewerproperty to UserAccessState mocks in CheckRunNow testsid,name,status,playbook_run_id,start_time) to CategorizedPlaybookRunAction mocksactionsarray to Playbook specnameproperty to PlaybookActionTest plan
npm run typecheckpasses with no errors