feat: set object_selector when playbook is selected in permission form #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a playbook is selected in the permission form, automatically populate object_selector with the playbook name and wildcard configs selector to enable proper resource-based permissions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adityathebe
commented
Oct 10, 2025
| required | ||
| name="playbook_id" | ||
| playbookResourceSelector={[{}]} | ||
| onValueChange={(value, option) => { |
There was a problem hiding this comment.
Temporary fix until we hadd resource selector to the form
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
object_selectorfield when a playbook is selected in the permission formChanges
onValueChangecallback prop toFormikResourceSelectorDropdownto pass the full selected option dataFormikPermissionSelectResourceFieldsto setobject_selectorwith the format:{"playbooks": [{"name": "<selected-playbook>"}], "configs": [{"name": "*"}]}Test plan
object_selectorfield correctlyobject_selectorfield