Cleaner reproducible lighthouse #38
Draft
+46
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhulbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Lighthouse release candidate adds a sysmalloc feature which we can able to avoid having to patch lighthouse to get reproducible builds. Fixing the underlying issue is outside of the scope of the upstream lighthouse repo since they use Docker for their reproducible builds, which unlike chroots or even the Lima VMs, hides the CPU flags from jemalloc, avoiding the issue.
I'm going to keep this as a draft until lighthouse v8 comes out, at which point I'll restructure the code a bit to make it so we can just use the regular build_rust_package rather than calling cargo manually.