Implement L2 BoB #40
Draft
Implement L2 BoB #40
+300
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements L2 BoB support for GCP deployment, focusing on adding a new bob-l2 image with op-node integration and improving build reproducibility for GCP images.
Key changes:
- Added complete bob-l2 image configuration with op-node support
- Enhanced GCP disk image creation with deterministic/reproducible builds
- Updated build scripts to handle directory artifacts in addition to file artifacts
Reviewed Changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| bob-l2.conf | Root configuration for the new bob-l2 image |
| bob-l2/mkosi.conf | Build and package configuration for bob-l2 |
| bob-l2/mkosi.build | Build script for op-node binary |
| bob-l2/mkosi.postinst | Post-installation setup for bob-l2 services |
| bob-l2/mkosi.extra/* | Service definitions, firewall rules, and configuration files |
| bob-l2/kernel.config | Kernel configuration snippet for L2 networking |
| scripts/make_git_package.sh | Enhanced to support directory artifacts |
| mkosi.profiles/gcp/mkosi.postoutput | Improved with deterministic disk image creation |
| mkosi.profiles/gcp/mkosi.extra/* | Added GCP-specific udev rules and system configuration |
| services/chrony.conf | Chrony NTP configuration for GCP metadata server |
| kernel/snippets/ubuntu.config | Ubuntu kernel configuration baseline |
| kernel/mkosi.build | Updated default kernel version to 6.15.8 |
| bob-common/* | Enhanced searcher shell to support op-node operations |
| bob-l1/* | Moved openntpd to L1-specific configuration |
| base/* | Refined debloat script to preserve bash-completion in devtools |
| flake.nix | Added measured-boot-gcp tool and additional build dependencies |
| buildernet/mkosi.conf | Added cargo to build packages |
| Makefile | Added measure-gcp target for GCP-specific measurements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ilyaluk
force-pushed
the
ilya/wip-l2-bob
branch
3 times, most recently
from
7fc7f12 to
81ea927
Compare
ilyaluk
force-pushed
the
ilya/wip-l2-bob
branch
from
1cc0187 to
095efe5
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much WiP