feat(tests): Add tests for Checkpoint and CheckpointExt #36
+354
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
requested review from
SozinM,
julio4 and
karim-agha
as code owners
julio4
reviewed
Oct 10, 2025
Collaborator
julio4
left a comment
julio4
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is a good start, but I have some recommendations:
Here we want to unit tests a sensible component used everywhere, so try to add tests focused on specific methods in these modules. Take the time to think of all possible inputs/outputs and find as much edge cases as possible. You don't have to tests all methods of this interface at once, but that for each one you try to test you cover it well.
julio4
approved these changes
Oct 20, 2025
julio4
force-pushed
the
varun/checkpoint-tests
branch
from
4d4bd86 to
ec94d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Will add more tests as advised ✔️