Skip to content

restore_landed_orders: fix restore for bundle with refund #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

restore_landed_orders: fix restore for bundle with refund #782

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e1d1c3
restore_landed_orders: fix restore for bundle with refund
dvush Oct 24, 2025
86afa8d
redistribution: downgrade legacy warnings
dvush Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/rbuilder/src/backtest/restore_landed_orders/find_landed_orders.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl SimplifiedOrder {
)],
),
Order::Bundle(bundle) => {
let (refund_percent, receiver_hash) = if let Some(refund) = &bundle.refund {
let (refund_percent, refund_payer_hash) = if let Some(refund) = &bundle.refund {
(refund.percent as usize, Some(refund.tx_hash))
} else {
(0, None)
Expand All @@ -55,10 +55,10 @@ impl SimplifiedOrder {
.list_txs_revert()
.into_iter()
.map(|(tx, revert)| {
let tx_refund_percent = if Some(tx.hash()) == receiver_hash {
0
} else {
let tx_refund_percent = if Some(tx.hash()) == refund_payer_hash {
refund_percent
} else {
0
};
OrderTxData::new(tx.hash(), revert, tx_refund_percent)
})
Expand Down Expand Up @@ -1000,7 +1000,7 @@ mod tests {
refund: Some(BundleRefund {
percent: 10,
recipient: Default::default(),
tx_hash: hash(0x01),
tx_hash: hash(0x02),
delayed: false,
}),
refund_identity: None,
Expand Down
Loading