Fix bias dtype #1876
Open
Fix bias dtype #1876
+151
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanimajety
reviewed
Oct 6, 2025
…ode. Signed-off-by: Christina Zhang <83400082+ChristinaZ@users.noreply.github.com>
pavanimajety
reviewed
Oct 9, 2025
pavanimajety
reviewed
Oct 9, 2025
pavanimajety
reviewed
Oct 9, 2025
|
@ChristinaZ Thanks for making changes across all MOE runners! |
pavanimajety
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
LGTM, thanks @wenscarl and @ChristinaZ for making the required changes!
|
@yzh119 could you take a look and merge it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
co-authored by @ChristinaZ(major contribution)
After this change, for deepseek mode, now logits is always fp32, bias can be bfloat16 and fp32 now.
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes