Tom/minor enhancement autograd quickstart #276
Conversation
There was a problem hiding this comment.
@daquinteroflex could you double check this? specifically, i'm not sure which branches are relevant for linting in the notebooks repo
|
@tomflexcompute currently quite a few lint rules failing. not sure if we should exclude some of those or just bite the bullet and change the notebooks? |
|
Let me try to resolve them as much as possible. |
|
So it turns out I only modified a few. Some errors are not super clear to me what they are referring to. Some don't seem necessary. Some notebooks (like the surrogate model) are too long to run so I don't want to rerun them. Maybe we can live with that for now. Typos should be pretty much all fixed. I didn't bother to edit the adjoint ones since they are deprecating. Also a few suggested typos are not typos, e.g. author names from the cited paper. |
|
@tomflexcompute fyi everything is passing now, should we sqash and merge? |
|
Yes looks very good! |
Fixed notebook lint errors Fixed notebook typos Update quick start notebook to simple gradient decent
tomflexcompute
force-pushed
the
tom/minor_enhancement_autograd_quickstart
branch
from
bcbdc67 to
08c6998
Compare
Minor revision again of the autograd quickstart again according to Zongfu's feedback.
Ran a typo checker on all notebooks and found a good number of typos. Thus the giant number of changes in this PR. Probably should've done it earlier,