-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Updated Thermo optic doped modulator to use non isothermal Charge #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Spell Check ReportThermoOpticDopedModulator.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
|
That is great, Marc, thanks! Just to double-check, the simulations are independent, not coupled? It solves for the current and then uses that current to calculate the heat, is that correct? At cell [18], I think these lines can be removed: This is totally optional, but I think it would be better to create an instance of the batch object, in case the user needs to abort the simulation:
|
|
Also, is it possible to have an API function to wrap the interpolation at cell [31]. Something like this: So for the user side, it just needs to call: If something like that is possible, I think it would create a cleaner workflow for demos and also highlight the integration of our solvers, which adds significant value. |
51eaab1 to
2656c5e
Compare
|
@FilipeFcp that piece of code was outdated. |
|
Thanks @marc-flex! |
|
@momchil-flex I have addressed your comments. Only this is missing:
Monitors have infinite sizes so they'll always be there regardless of where the z is defined?
I need to investigate that actually. It shouldn't be too different from the heat plot.
I'd say the increased cost is probably small since the mesh is coarser outside the semiconductor. Plus we're only meshing |
Thanks!
Ah, in FDTD sims we often make the monitor 0D along the 0 dimension, which is what I was imagining here but it's not the case. I am not sure if doing this will cause some issues with e.g. numerical precision but maybe good to know/try?
Great. |

This new version of the Thermo-optic doped modulator unifies the existing Charge and Heat simulation into a single non-isothermal Charge simulation. As a result, the notebook is significantly simplified.
To ease convergence of the thermal charge case, the doping distribution has been changed slightly. It now uses gaussian boxes so that the transition between p and p+ regions goes a bit more smoothly, which helps convergence and reduces the very high local electric field in those transitions.
Additional plots have been added to directly visualize carrier and temperature distributions evolution with applied voltage