-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Add natural convection BC #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbe0d31
to
f737cae
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f737cae
to
bbe0d31
Compare
This comment was marked as resolved.
This comment was marked as resolved.
marc-flex
reviewed
Aug 21, 2025
2e9f493
to
e48989a
Compare
e48989a
to
c6b941e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
c6b941e
to
25cd6b2
Compare
a424309
to
8e8cf4f
Compare
8e8cf4f
to
fbf5747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR introduces a new
NaturalConvectionVerticalSpec
class to enhance thermal boundary condition modeling in the Tidy3D framework. The class enables automatic calculation of heat transfer coefficients for natural convection from vertical plates based on fluid properties rather than requiring manual coefficient specification.The implementation follows standard heat transfer engineering practices by using Rayleigh number calculations and appropriate Nusselt number correlations to determine heat transfer coefficients. It supports both laminar and turbulent flow regimes based on critical Rayleigh number thresholds. The class accepts comprehensive fluid property inputs including thermal conductivity, viscosity, density, specific heat, and thermal expansion coefficient.
The integration is achieved by extending the existing
ConvectionBC.transfer_coeff
field to accept either a simple float (existing behavior) or the newNaturalConvectionVerticalSpec
object, maintaining backward compatibility. The class is properly exported through the main package interface and integrated into the TCAD types system, following established patterns in the codebase for thermal boundary conditions.Confidence score: 2/5
_compute_parameters
method returns unused values suggesting incomplete integrationtidy3d/components/tcad/boundary/heat.py
needs immediate attention for unit consistency, parameter validation, and completion of the computation logic