-
Notifications
You must be signed in to change notification settings - Fork 8
Refactors #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fadrian06
wants to merge
52
commits into
master
Choose a base branch
from
refactors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactors #29
Changes from 3 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
03c44ad
ignore apm_fallback.log
fadrian06 86250f9
fix warning about optional parameter before required parameter in php…
fadrian06 d2bb4c3
composer require flightphp/apm:^0.4.1 flightphp/core:^3.17 -W & compo…
fadrian06 16fbe8f
composer rector
fadrian06 81dfe72
npx @biomejs/biome check --write **/*.js **/*.css **/*.json
fadrian06 83bcc1c
ensure newline at end of files
fadrian06 3c26c75
phpcbf --standard=PSR12 app/ public/index.php rector.php swoole_serve…
fadrian06 6844c95
rename CustomFlight -> CustomEngine
fadrian06 8dce425
change require to require_once in swoole_server.php
fadrian06 19d1d5a
add type coercions in translate_content.php
fadrian06 294ed2d
composer require symfony/var-dumper:^7.3 --dev -W
fadrian06 c045a59
mb_internal_encoding and setlocale were added since php 4
fadrian06 75e8a9e
middleware usage simplification
fadrian06 fac2984
simplify $app declaration in config_sample.php
fadrian06 1ae39b4
$rootDir variable extraction in config_sample.php
fadrian06 fa09cc3
Tracy\Debugger::DEVELOPMENT @deprecated use Debugger::Development
fadrian06 10a22a5
reduce line lengths in config_sample.php
fadrian06 7245c72
mark HeaderSecurityMiddleware as final
fadrian06 7608763
documented HeaderSecurityMiddleware::$nonce
fadrian06 08955d2
apply code style in HeaderSecurityMiddleware::before
fadrian06 6f5d0cc
treat nullable $executedRoute in HeaderSecurityMiddleware
fadrian06 e3d92c5
extract $oneDay variable in HeaderSecurityMiddleware::after
fadrian06 d36fc8b
composer require flightphp/container -W
fadrian06 31cf17f
fix autoload of app/utils/CustomEngine
fadrian06 e7a3ac2
simplify notFound route
fadrian06 a319e99
sort DocsLogic members
fadrian06 c46a506
replace $this->app->latte by $this->latte from the container
fadrian06 d7b7b5a
add void return types in HeaderSecurityMiddleware
fadrian06 c1c3d05
add Swoole\Engine validation
fadrian06 76abc35
change fqcn SwooleServerDriver usage for local use
fadrian06 d63d2df
normalize line spacing in routes.php
fadrian06 dfafd26
mark CustomEngine class as final
fadrian06 568b234
add rector --dry-run to composer lint script
fadrian06 30d7038
ignore StringClassNameToClassConstantRector rector rule
fadrian06 eab7601
remove DocsLogic::latte property for compatibility with DocsController
fadrian06 e240bb0
mark DocsController as final readonly and $app property as private
fadrian06 101fbac
set lang html attribute dinamically
fadrian06 f343b80
improve format of layout.latte -> head
fadrian06 ffaa83a
improve format of links.latte
fadrian06 56cea79
improve spacing in DocsLogic::compileScrollspyPage
fadrian06 4dddbe1
update bootstrap and bootstrap-icons
fadrian06 da82b9e
remove $ds variable
fadrian06 3a4e624
remove $app usage in config_sample.php
fadrian06 edea803
remove $app usage in bootstrap.php - variable remains for compatibility
fadrian06 fe292fb
remove $app usage in routes.php
fadrian06 f1a24db
fix /single-page in windows
fadrian06 00f736c
fix /search in windows
fadrian06 4a028c3
add cache singleton in the container
fadrian06 d7005be
empty comment to force brackets in different lines in sublime text ls…
fadrian06 54d6b75
improve naming in services.php
fadrian06 b65d78f
simplify DocsController, improve naming, typing and remove unnecesary…
fadrian06 af4d9de
improve spacing
fadrian06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,5 @@ app/cache/ | |
| *.sublime-* | ||
| biome.* | ||
| .runway-config.json | ||
| apm.db* | ||
| apm.db* | ||
| apm_fallback.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the default value
= []from the&$heading_dataparameter is a breaking change. Callers that previously relied on this parameter being optional will now get a fatal error. Consider keeping the default value or updating all call sites to explicitly pass an array.Copilot uses AI. Check for mistakes.