Simulate file handling in qsieve #1625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinahlback
force-pushed
the
qsieve_simulate_file
branch
from
3be9cf7 to
3e3cf40
Compare
Collaborator
Author
|
Currently, this is about 0.6% slower when factoring so I will try to speed it up first before merging anything. |
Collaborator
|
0.6% is hardly measurable. Are you sure it's not just random noise? |
Collaborator
Author
Perhaps, but I'm pretty sure it is actually is slower. Could be that pushing everything to RAM instead of storage introduces more cache misses. If you feel like it is worth a small slowdown to go away from temporary storage, please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to work just fine. Want to say that using
QS_SIQS_FSEEK_SEEK_CURwill not work if you are going to write, it will only work if you are going to read.Solves #708, but could very much be improved.