ViewStack: Store View by value to save memory #4285
+33
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This PR changes
ViewStackto storeViewby value, rather than by a pointer. The stack already has knowledge of View's internals, so this doesn't introduce any new dependencies, but reduces memory usage and fragmentation, as before this change, the view stack was only a pointer to a single view anyway.Results in a miniscule reduction in memory usage on the main Desktop screen. This is expected, as this change amounts to one allocation less per each ViewStack.
Before:
After:
Verification
Checklist (For Reviewer)