Skip to content

[REPL] Linter query completions #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 28, 2025
Merged

[REPL] Linter query completions #1993

merged 22 commits into from
Oct 28, 2025

Conversation

@MaxAtoms
Copy link
Collaborator

Adds CLI completions for the linter query REPL command:

image

MaxAtoms added 16 commits October 23, 2025 10:21
@MaxAtoms
feat-fix(repl): respect new arg in queries
8a3f0bc 
Previously, all queries would be returned when trying to complete ':query @dataflow '.
@MaxAtoms
feat-fix(repl): parse help command correctly
1406e28
@MaxAtoms
feat(repl): add line parser for linter
167041d
@MaxAtoms
feat(repl): parse input for each query separately
edfca59
@MaxAtoms
feat(repl): centralize input processing for queries
6c3355e
@MaxAtoms
refactor(repl): review comments
3de1af3
@MaxAtoms
feat-fix(analyzer): analyzer should control request changes
df03321
@MaxAtoms
feat(repl): use output to print error messages
ce02fab
@MaxAtoms
refactor(repl): introduce variable
d3162ad
@MaxAtoms
refactor(analyzer): introduce ModifiableFlowrAnalysisProvider
775da56
@MaxAtoms
Merge remote-tracking branch 'origin/main' into linter-query-parser
24510fb
@MaxAtoms
feat-fix(repl): set correct field
bbe0d9f
@MaxAtoms
refactor(analyzer): rename interfaces
ad3b6df
@MaxAtoms
feat(repl): linter completions
de1b6e1
@MaxAtoms
refactor(repl): omit empty array creation
59adc38
@MaxAtoms
feat(repl): complete current linter rule only
9ce8476
@MaxAtoms MaxAtoms requested a review from EagleoutIce October 27, 2025 13:29
@MaxAtoms MaxAtoms self-assigned this Oct 27, 2025
@MaxAtoms
Copy link
Collaborator Author

The sub-string argument (see below) of Node readline is a bit awkwardly handled right now.
@Ellpeck told me you discussed the peculiarities of the completer API before.

image

Base automatically changed from linter-query-parser to main October 27, 2025 16:37
@EagleoutIce
Copy link
Member

"Right now" is such a funny thing to say for something that is probably permanent 🤣

EagleoutIce
EagleoutIce approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@EagleoutIce EagleoutIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general fine, I would just love to have a unit or maybe even system test for the completions to trigger? I think a unit test would be easier, just to check whether rule:d<complete> contains (at least) the rules we like and only rules starting with d etc.

EagleoutIce
EagleoutIce approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@EagleoutIce EagleoutIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! :)

EagleoutIce
EagleoutIce reviewed Oct 28, 2025
View reviewed changes
@MaxAtoms MaxAtoms requested a review from EagleoutIce October 28, 2025 20:50
@EagleoutIce EagleoutIce merged commit 4ed7cb1 into main Oct 28, 2025
19 checks passed
@EagleoutIce EagleoutIce deleted the linter-query-completions branch October 28, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EagleoutIce EagleoutIce EagleoutIce approved these changes

Assignees

@MaxAtoms MaxAtoms

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxAtoms @EagleoutIce