Skip to content

CI: add ruby 4.0 #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenhys merged 1 commit into from
Jan 6, 2026
Merged

CI: add ruby 4.0 #5211

kenhys merged 1 commit into from
Jan 6, 2026

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Jan 2, 2026

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

Docs Changes:
N/A

Release Note:
N/A

@Watson1978
Copy link
Contributor Author

Watson1978 commented Jan 2, 2026 •
edited
Loading

The exact reason is unclear, but in Ruby 4.0, "win32/registry" is not loaded properly when editing the registry.

DEBUG:   60+  >>>> ruby bin/fluentd --reg-winsvc-fluentdopt "-c '$current_path/duplicated_id.conf' -o '$log_path'"

D:/a/fluentd/fluentd/lib/fluent/command/fluentd.rb:347:in '<top (required)>': uninitialized constant Win32::Registry (NameError)

  Win32::Registry::HKEY_LOCAL_MACHINE.open("SYSTEM\\CurrentControlSet\\Services\\#{opts[:winsvc_name]}", Win32::Registry::KEY_ALL_ACCESS) do |reg|

       ^^^^^^^^^^
	from bin/fluentd:15:in 'Kernel#require'
	from bin/fluentd:15:in '<main>'

Ref. https://github.com/fluent/fluentd/actions/runs/20650937408/job/59296698869

@Watson1978 Watson1978 marked this pull request as draft January 2, 2026 07:46
@Watson1978
Copy link
Contributor Author

Watson1978 commented Jan 5, 2026

Separated the PR into #5213

@Watson1978
CI: add ruby 4.0
9a5a08a 
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 added CI Test/CI issues backport to v1.19 We will backport this fix to the LTS branch labels Jan 5, 2026
@Watson1978 Watson1978 marked this pull request as ready for review January 5, 2026 05:24
kenhys
kenhys approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 9aa0a5b into fluent:master Jan 6, 2026
21 checks passed
@Watson1978 Watson1978 deleted the ci/add-ruby-4.0 branch January 6, 2026 05:24
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Jan 8, 2026
@Watson1978 @kenhys
Backport(v1.19) CI: add ruby 4.0 (fluent#5211)
6a00987 
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Jan 8, 2026
Merged
Watson1978 added a commit that referenced this pull request Jan 8, 2026
@kenhys @Watson1978
Backport(v1.19) CI: add ruby 4.0 (#5211) (#5225)
0bceb40 
**Which issue(s) this PR fixes**:

Backport: #5211 
Fixes #

**What this PR does / why we need it**:

**Docs Changes**:

N/A

**Release Note**:

N/A

---------

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenhys kenhys kenhys approved these changes

Assignees

No one assigned

Labels

backport to v1.19 We will backport this fix to the LTS branch CI Test/CI issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Watson1978 @kenhys