Skip to content

Convert console log manager to PluginLogger #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Convert console log manager to PluginLogger #8524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/io/flutter/logging/FlutterConsoleLogManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
* console.
*/
public class FlutterConsoleLogManager {
private static final @NotNull Logger LOG = Logger.getInstance(FlutterConsoleLogManager.class);
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterConsoleLogManager.class);

private static final String consolePreferencesSetKey = "io.flutter.console.preferencesSet";
private static final String DEEP_LINK_GROUP_ID = "deeplink";
Expand Down Expand Up @@ -135,7 +135,11 @@ public void handleFlutterErrorEvent(@NotNull Event event) {
processFlutterErrorEvent(diagnosticsNode);
}
catch (Throwable t) {
LOG.warn(t);
if (FlutterSettings.getInstance().isVerboseLogging()) {
LOG.warn(t);
} else {
LOG.warn("Error processing FlutterErrorEvent: " + t.getMessage());
}
}
finally {
queueLength.decrementAndGet();
Expand All @@ -148,7 +152,11 @@ public void handleFlutterErrorEvent(@NotNull Event event) {
}
}
catch (Throwable t) {
LOG.warn(t);
if (FlutterSettings.getInstance().isFilePathLoggingEnabled()) {
LOG.warn(t);
} else {
LOG.warn("Error handling FlutterErrorEvent: " + t.getMessage());
}
}
}

Expand All @@ -166,7 +174,11 @@ public void flushFlutterErrorQueue() {
}
}
catch (InterruptedException e) {
LOG.error(e);
if (FlutterSettings.getInstance().isVerboseLogging()) {
LOG.error(e);
} else {
LOG.error("Exception when flushing FlutterErrorQueue: " + e.getMessage());
}
}
}
}
Expand Down Expand Up @@ -411,7 +423,11 @@ public void handleLoggingEvent(@NotNull Event event) {
processLoggingEvent(event);
}
catch (Throwable t) {
LOG.warn(t);
if (FlutterSettings.getInstance().isVerboseLogging()) {
LOG.warn(t);
} else {
LOG.warn("Error processing LoggingEvent: " + t.getMessage());
}
}
});
}
Expand Down