Skip to content

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Oct 9, 2025

This shows the project view for flutter projects on first open:
Screenshot 2025-10-09 at 9 45 30 AM

There's a problem with this fix though, in this scenario:

  1. Open the flutter project (this will open to the project view correctly)
  2. Close the project
  3. Open the project's Android subdirectory (this will open to the android view correctly)
  4. Open the top-level flutter project again - this will open to the android view, which isn't what we want

So I don't even know if I want to commit this code, because it feels like we are trying to manipulate a mechanism that's already pretty complicated. Any opinions are welcome.

(mostly) Fixes 8556

@helin24 helin24 requested review from jwren and pq October 9, 2025 20:46
Copy link
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels tricky and I'm with you completely in asking if we want to have bespoke special-case code like this in general. Here, it does seem like an improvement to the common case so maybe worth committing? If you feel that, I'd ask for you to add some notes to the implementation reflecting the limitation and maybe a link back to #8556 so we can replay this conversation easily down the road if needed.

Thanks for putting so much thought into this!

@helin24
Copy link
Member Author

helin24 commented Oct 10, 2025

Thanks for the suggestions! I agree, it should be helpful for the majority of cases. When we have analytics, it would be nice to know how often users are opening the android subdirectory and using that workflow for editing native code.

@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Oct 10, 2025
@auto-submit auto-submit bot merged commit 4bd5669 into flutter:main Oct 10, 2025
7 checks passed
auto-submit bot pushed a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When opening a new Flutter project in Android Studio, open top level directory

2 participants