feat(android): add audio track selection for ExoPlayer #10312

nateshmbhat · 2025-10-28T15:03:02Z

Implemented getAudioTracks() and selectAudioTrack() methods for Android video player

Android PR for : #9925

Pre-Review Checklist

gemini-code-assist

Code Review

The pull request implements audio track selection for ExoPlayer in the Android video player. It adds getAudioTracks() and selectAudioTrack() methods, updates the Pigeon definitions, modifies the ExoPlayerEventListener to handle buffering states, and includes corresponding tests. The changes also involve removing Kotlin-related configurations from build.gradle and updating the CHANGELOG.md file.

gemini-code-assist · 2025-10-28T15:07:19Z

...yer_android/android/src/main/java/io/flutter/plugins/videoplayer/ExoPlayerEventListener.java

+  private void setBuffering(boolean buffering) {
+    if (isBuffering == buffering) {
+      return;
+    }
+    isBuffering = buffering;
+    if (buffering) {
+      events.onBufferingStart();
+    } else {
+      events.onBufferingEnd();
+    }


This method encapsulates the logic for setting the buffering state and invoking the corresponding callbacks. It checks if the buffering state has changed before invoking the callbacks, preventing redundant calls. This is a good practice for optimizing performance and avoiding unnecessary UI updates. However, there is no error handling for the callback invocations. Consider adding try-catch blocks around the callback invocations to handle potential exceptions and prevent crashes.

gemini-code-assist · 2025-10-28T15:07:19Z

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

+  public @NonNull Messages.PlaybackState getPlaybackState() {
+    return new Messages.PlaybackState.Builder()
+        .setPlayPosition(exoPlayer.getCurrentPosition())
+        .setBufferPosition(exoPlayer.getBufferedPosition())
+        .build();


The getPlaybackState method creates and returns a PlaybackState object with the current play and buffer positions. This is a good approach for encapsulating the playback state and providing a consistent way to access it. However, the method does not handle potential exceptions that might occur when accessing the ExoPlayer's state. Consider adding error handling to gracefully handle exceptions and prevent crashes.

gemini-code-assist · 2025-10-28T15:07:19Z

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

+  public void selectAudioTrack(@NonNull String trackId) {
+    if (trackSelector == null) {
+      Log.w("VideoPlayer", "Cannot select audio track: track selector is null");
+      return;
+    }


It's important to handle the case where trackSelector is null to prevent NullPointerException. Logging a warning is a good approach, but consider throwing an exception or returning an error code to the Flutter side to indicate that audio track selection is not supported in this case. This would allow the Flutter app to handle the situation gracefully and provide feedback to the user.

gemini-code-assist · 2025-10-28T15:07:19Z

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

+      trackSelector.setParameters(
+          trackSelector.buildUponParameters().setOverrideForType(override).build());


The setParameters method can throw exceptions if the provided parameters are invalid or if there is an issue with the underlying player. Consider adding a try-catch block around this call to handle potential exceptions and prevent crashes. Log the exception for debugging purposes.

gemini-code-assist · 2025-10-28T15:07:20Z

..._android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerEventCallbacks.java

+    Map<String, Object> event = new HashMap<>();
+    event.put("event", "initialized");
+    event.put("width", width);
+    event.put("height", height);
+    event.put("duration", durationInMs);
+    if (rotationCorrectionInDegrees != 0) {
+      event.put("rotationCorrection", rotationCorrectionInDegrees);
+    }
+    eventSink.success(event);


The onInitialized method constructs a Map to represent the initialization event. This is a good approach for sending structured data to the Flutter side. However, the code does not handle potential exceptions that might occur when putting values into the Map. Consider adding error handling to gracefully handle exceptions and prevent crashes.

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

- Added getAudioTracks() method to retrieve available audio tracks with metadata (bitrate, sample rate, channel count, codec) - Added selectAudioTrack() method to switch between audio tracks using ExoPlayer's track selector - Implemented onTracksChanged listener to notify when audio track selection changes

nateshmbhat · 2025-11-07T16:29:15Z

as we don't wanna do breaking changes to the platform interface @ash2moon have moved the trackindex/groupindex handling logic parsing/encoding logic to the dart side. Please check pr

nateshmbhat · 2025-11-14T15:02:10Z

@camsim99 can you please review this PR ?

camsim99

Overall this is looking good! Left some comments, sorry for the delay.

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

camsim99 · 2025-11-17T17:46:35Z

packages/video_player/video_player_android/lib/src/android_video_player.dart

+    try {
+      await _api.selectAudioTrack(groupIndex, trackIndex);
+
+      // Wait for the onTracksChanged event from ExoPlayer with a timeout


I would argue we don't need the Completer or any of this logic below. But, I think it's ok to just make the call to _api.selectAudioTrack and use the callback on the native side to just report if there were any issues selecting the track. Thoughts?

I acknowledge I may be missing some context here since I'm reviewing this PR before the main PR--let me know if so!

have tried earlier without waiting , for exoplayer there's a slight delay where in if i fetch the tracks right after selecting different track, it would still give me older values. so using this completer we're waiting to ensure that the track switch is finished before resolving the future. so that the developer can reliably get updated information when he calls getAudioTracks after he selects any track.

we had many discussions on this with different approaches which all had some caveats. this approach seemed to be the least risky and more reliable.

Okay gotcha! Can you do me a favor and point me towards the thread about this just so I can read the discussion too?

packages/video_player/video_player_android/lib/src/android_video_player.dart

...deo_player_android/android/src/test/java/io/flutter/plugins/videoplayer/AudioTracksTest.java

camsim99 · 2025-11-17T22:08:47Z

as we don't wanna do breaking changes to the platform interface @ash2moon have moved the trackindex/groupindex handling logic parsing/encoding logic to the dart side. Please check pr

Also to follow up on this: Is there a reason we don't just send the track index and group index over separately versus as a group_track concatenated String format as ash2moon mentioned?

…va/io/flutter/plugins/videoplayer/VideoPlayer.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

nateshmbhat · 2025-11-19T14:49:07Z

as we don't wanna do breaking changes to the platform interface @ash2moon have moved the trackindex/groupindex handling logic parsing/encoding logic to the dart side. Please check pr

Also to follow up on this: Is there a reason we don't just send the track index and group index over separately versus as a group_track concatenated String format as ash2moon mentioned?

initially the idea was to have a single track id which makes it more easy to manage for the developer using the library. also on ios there's no group index. so it was done in that way.

…ion and consolidate tests - Replaced try-catch with explicit bounds checking for groupIndex and trackIndex - Added validation for negative indices - Removed redundant error handling logic - Consolidated audio track tests from separate AudioTracksTest.java into VideoPlayerTest.java - Improved code readability by removing nested conditional logic

…ter_packages into 28-oct-platform-android

… and fix formatting - Added test to verify isAudioTrackSupportAvailable returns true - Provided dummy values for NativeAudioTrackData and Future types in test setup - Fixed import ordering to follow convention (package imports before java imports) - Removed trailing whitespace in VideoPlayerTest.java - Added comment clarifying that comprehensive audio track tests are in Java layer

nateshmbhat · 2025-11-24T05:59:11Z

@camsim99 just checking in 😄
Did you get a chance to review the changes ?

camsim99

Great progress here, thanks! Still think we need Dart tests and suggested some changes on the Java side.

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

camsim99 · 2025-11-24T17:11:44Z

packages/video_player/video_player_android/test/android_video_player_test.dart

+    group('audio tracks', () {
+      // Note: Comprehensive audio track functionality tests are in the Java layer
+      // (VideoPlayerTest.java) where the actual implementation resides.
+      // These Dart tests verify the platform interface integration.


While this is true, we still need tests for getAudioTracks and selectAudioTrack because there is logic in those methods to be tested.

added tests

camsim99 · 2025-11-24T17:20:16Z

packages/video_player/video_player_android/lib/src/android_video_player.dart

+    try {
+      await _api.selectAudioTrack(groupIndex, trackIndex);
+
+      // Wait for the onTracksChanged event from ExoPlayer with a timeout


Okay gotcha! Can you do me a favor and point me towards the thread about this just so I can read the discussion too?

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

…va/io/flutter/plugins/videoplayer/VideoPlayer.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

nateshmbhat · 2025-11-26T15:28:23Z

@camsim99 here's the thread regarding handling of track change completion : #9925 (comment)

Updated the PR as per your review comments.

…gs to exceptions - Changed selectAudioTrack() to throw IllegalStateException when track selector is null - Changed selectAudioTrack() to throw IllegalArgumentException for invalid indices and non-audio tracks - Updated tests to expect exceptions instead of verifying no API calls - Added try-finally blocks in tests to ensure proper cleanup - Removed unused Log import - Added comprehensive Dart tests for getAudioTracks() and selectA

…ter_packages into 28-oct-platform-android

nateshmbhat requested a review from ash2moon as a code owner October 28, 2025 15:03

github-actions bot added platform-android p: video_player labels Oct 28, 2025

gemini-code-assist bot reviewed Oct 28, 2025

View reviewed changes

nateshmbhat mentioned this pull request Oct 28, 2025

[video_player] Adds audio track metadata fetching and audio track selection feature #9925

Open

11 tasks

stuartmorgan-g added the triage-android Should be looked at in Android triage label Oct 28, 2025

ash2moon reviewed Oct 29, 2025

View reviewed changes

...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java Outdated Show resolved Hide resolved

nateshmbhat requested a review from ash2moon November 3, 2025 17:20

nateshmbhat mentioned this pull request Nov 7, 2025

refactor(video_player): replace audio track string ID with typed indices #10379

Closed

11 tasks

nateshmbhat force-pushed the 28-oct-platform-android branch from 77b0fce to b544b45 Compare November 7, 2025 16:27

Merge branch 'main' into 28-oct-platform-android

1fdb5d5

reidbaker requested review from a team and camsim99 and removed request for ash2moon November 11, 2025 18:09

nateshmbhat requested a review from ash2moon November 14, 2025 15:02

camsim99 reviewed Nov 17, 2025

View reviewed changes

Update packages/video_player/video_player_android/android/src/main/ja…

a0a9a0d

…va/io/flutter/plugins/videoplayer/VideoPlayer.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

nateshmbhat requested a review from reidbaker as a code owner November 19, 2025 14:40

nateshmbhat added 3 commits November 19, 2025 20:48

Merge branch '28-oct-platform-android' of github.com:nateshmbhat/flut…

8c776aa

…ter_packages into 28-oct-platform-android

nateshmbhat requested a review from camsim99 November 19, 2025 15:35

Merge branch 'main' into 28-oct-platform-android

f9d72fe

camsim99 reviewed Nov 24, 2025

View reviewed changes

Update packages/video_player/video_player_android/android/src/main/ja…

f0a3f38

…va/io/flutter/plugins/videoplayer/VideoPlayer.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

nateshmbhat requested a review from camsim99 November 26, 2025 15:56

nateshmbhat added 2 commits November 26, 2025 21:27

Merge branch 'main' into 28-oct-platform-android

308a341

Merge branch '28-oct-platform-android' of github.com:nateshmbhat/flut…

2bcef5f

…ter_packages into 28-oct-platform-android

		trackSelector.setParameters(
		trackSelector.buildUponParameters().setOverrideForType(override).build());

feat(android): add audio track selection for ExoPlayer #10312

Are you sure you want to change the base?

feat(android): add audio track selection for ExoPlayer #10312

Uh oh!

Conversation

nateshmbhat commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nateshmbhat commented Nov 7, 2025

Uh oh!

nateshmbhat commented Nov 14, 2025

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camsim99 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

nateshmbhat Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

camsim99 commented Nov 17, 2025

Uh oh!

nateshmbhat commented Nov 19, 2025

Uh oh!

nateshmbhat commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

camsim99 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

nateshmbhat Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nateshmbhat commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

nateshmbhat commented Oct 28, 2025 •

edited

Loading

nateshmbhat commented Nov 24, 2025 •

edited

Loading

nateshmbhat commented Nov 26, 2025 •

edited

Loading