Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Nov 10, 2025

Added AGP tooling for bulk updating agp versions in examples plugins.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@jesswrd jesswrd requested a review from camsim99 November 10, 2025 20:13
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tooling to allow bulk updates of the Android Gradle Plugin (AGP) version in packages. The changes include adding a new option to the update-dependency command, implementing the logic to find and replace the AGP version in settings.gradle files, and adding corresponding tests.

My review focuses on improving the robustness of the new logic and the maintainability of the tests. I've identified a potential crash if settings.gradle is missing and suggested a fix. I've also pointed out some duplicated test code that could be refactored.

@jesswrd jesswrd requested a review from a team November 12, 2025 20:53
@jesswrd jesswrd requested a review from mboetger November 13, 2025 00:03
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2025
@auto-submit auto-submit bot merged commit 799b62c into flutter:main Nov 13, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 13, 2025
flutter/packages@e5ecaf7...799b62c

2025-11-13 jessiewong401@gmail.com Added Tooling For AGP Bulk Update
(flutter/packages#10394)
2025-11-12 engine-flutter-autoroll@skia.org Manual roll Flutter from
31a8481 to ee23168 (14 revisions) (flutter/packages#10408)
2025-11-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
adc9010 to a0e9b9d (1232 revisions) (flutter/packages#10409)
2025-11-12 stuartmorgan@google.com Update repo for 3.38
(flutter/packages#10405)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants