-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[google_sign_in_android] Fix typos in README.md #10402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request corrects two typos in the README.md for the google_sign_in_android package. The changes fix a grammatical error and a spelling mistake, improving the clarity of the documentation.
While the code changes are correct, please note a couple of points regarding the pull request itself to align with the repository's contribution guidelines:
- The PR title should be prefixed with the package name in square brackets. For this PR, it should be
[google_sign_in_android] Fix typos in README.md. - The PR description should be filled out, and it should link to the issue that this PR resolves.
|
Approved but you will need to add a new version and changelog so that these changes can be published. |
Improves README and fixes minor typos.
Thanks! Changelog has been updated with the new version. |
flutter/packages@7063d75...e5ecaf7 2025-11-12 124445418+zhoda-lii@users.noreply.github.com [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 10687576+bparrishMines@users.noreply.github.com [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 stuartmorgan@google.com [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 jessiewong401@gmail.com Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
typo: from "recieve" to "receive"; from "use" to "using"
updated changelog to 7.2.4
discovered while investigating how to use google_sign_in auth for android and found: #10246
Pre-Review Checklist
[shared_preferences]///).CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3