-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update Google Fonts to v7.0.0 with new and removed fonts #10713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google_fonts package to version 7.0.0, introducing a substantial number of new fonts while removing several older ones. The changes include updating the CHANGELOG.md to reflect these additions and removals, modifying the families_supported list in the generator, and updating numerous part_*.g.dart files to include new font definitions (e.g., Doto, Faculty Glyphic, Geist, Google Sans Code, Hind Mysuru, Host Grotesk, Hubot Sans, Huninn, Iansui, Intel One Mono, Kanchenjunga, Kapakana, Karla Tamil Inclined, Karla Tamil Upright, TikTok Sans, Tirra, Triodion, Tuffy, UoqMunThenKhung, Vend Sans, WDXL Lubrifont JP N, WDXL Lubrifont SC, WDXL Lubrifont TC, Winky Rough, Winky Sans, Zalando Sans, Zalando Sans Expanded, Zalando Sans SemiExpanded) and remove others (e.g., IBM Plex Sans Condensed, Open Sans Condensed, Roboto Condensed, Saira Condensed variants). Many existing font hashes and sizes were also updated across the generated Dart files, indicating underlying font file changes.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is an awesome update, thank you!
LGTM
Added support for numerous new fonts and removed several deprecated or replaced fonts as part of the 7.0.0 update. Updated the font family lists, generated font part files, and the changelog to reflect these changes. This corresponds to directory 11, generated in December 2025.
Changed the fontWeight in generated_font_methods_test.dart from FontWeight.w600 to FontWeight(549) to test behavior with non-standard font weights.
83f2736 to
c59d827
Compare
dart generator/generator.dartadds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 11, generated in December 2025.