Skip to content

Conversation

@zemanux
Copy link
Contributor

@zemanux zemanux commented Jan 7, 2026

Issues fixed by this PR (if any): flutter/flutter#180534
PRs or commits this PR depends on (if any): flutter/flutter#180538

cc @loic-sharma @chunhtai

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@zemanux zemanux requested review from a team and sfshaza2 as code owners January 7, 2026 08:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zemanux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses ambiguity in Flutter's testing framework by deprecating the containsSemantics matcher. It introduces isSemantics for partial matching and matchesSemantics for exact matching, providing clearer and more standardized conventions for semantic property assertions. A comprehensive breaking change document has been added to facilitate a smooth migration for developers.

Highlights

  • Deprecation of containsSemantics: The containsSemantics matcher has been deprecated due to its ambiguous behavior regarding partial vs. exact matching of semantic properties.
  • Introduction of new matchers: Two new matchers, isSemantics and matchesSemantics, have been introduced to provide clearer intent: isSemantics for partial matching and matchesSemantics for exact matching.
  • New Breaking Change Document: A new breaking change document, deprecate-contains-semantics.md, has been added to guide developers through the migration from containsSemantics to the new matchers.
  • Updated Breaking Changes Index: The main index.md for breaking changes has been updated to include a reference to the new deprecation document.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request documents the deprecation of containsSemantics by adding a new breaking change page and updating the index. The documentation is clear and well-written. I've left a few comments regarding style and consistency, such as adhering to the line length limit and maintaining alphabetical order in lists, which will improve the documentation's quality.

@zemanux zemanux force-pushed the deprecate-contains-semantics branch from 4afe8ef to 3d2aa24 Compare January 7, 2026 09:56
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once @chunhtai approves.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Jan 7, 2026

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 7, 2026

Visit the preview URL for this PR (updated for commit 13654f3):

https://flutter-docs-prod--pr12891-deprecate-contains-semantic-aydgfy9d.web.app

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the last comment is addressed

@zemanux zemanux force-pushed the deprecate-contains-semantics branch from 871d606 to d8bc1a3 Compare January 7, 2026 19:57
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

chunhtai commented Jan 7, 2026

/gcbrun

@chunhtai
Copy link
Contributor

chunhtai commented Jan 7, 2026

/gcbrun

@sfshaza2 sfshaza2 merged commit 984242e into flutter:main Jan 7, 2026
10 checks passed
@zemanux zemanux deleted the deprecate-contains-semantics branch January 8, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants