-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Deprecate containsSemantics #12891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate containsSemantics #12891
Conversation
Summary of ChangesHello @zemanux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses ambiguity in Flutter's testing framework by deprecating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request documents the deprecation of containsSemantics by adding a new breaking change page and updating the index. The documentation is clear and well-written. I've left a few comments regarding style and consistency, such as adhering to the line length limit and maintaining alphabetical order in lists, which will improve the documentation's quality.
src/content/release/breaking-changes/deprecate-contains-semantics.md
Outdated
Show resolved
Hide resolved
4afe8ef to
3d2aa24
Compare
src/content/release/breaking-changes/deprecate-contains-semantics.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/deprecate-contains-semantics.md
Outdated
Show resolved
Hide resolved
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, once @chunhtai approves.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 13654f3): https://flutter-docs-prod--pr12891-deprecate-contains-semantic-aydgfy9d.web.app |
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the last comment is addressed
871d606 to
d8bc1a3
Compare
loic-sharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/gcbrun |
|
/gcbrun |
Issues fixed by this PR (if any): flutter/flutter#180534
PRs or commits this PR depends on (if any): flutter/flutter#180538
cc @loic-sharma @chunhtai
Presubmit checklist
of 80 characters or fewer.