-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update banner to call out AI best practices docs #12903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the website's prominent banner to feature a call to action for new AI best practices documentation. The change aims to direct users to relevant and current resources, replacing an outdated link to a past event. This ensures visitors are immediately informed about valuable new content related to building AI-powered applications with Flutter. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the site-wide banner to promote the new AI best practices documentation. The change is straightforward and the link path appears correct. I have one suggestion to improve the banner's responsiveness on smaller screens by shortening the link text, which also addresses your question about the wording.
| Check out our newly published best practices for | ||
| <a href="/ai/best-practices">building AI-powered apps with Flutter!</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text within the <a> tag, "building AI-powered apps with Flutter!", is quite long. The banner's CSS (site/lib/_sass/components/_banner.scss) applies white-space: nowrap; to links, which will prevent this text from wrapping. On smaller screens, this could cause a layout issue where the banner overflows its container.
To improve responsiveness and address the open question in your PR description about wording, I suggest rephrasing the banner content to use a shorter and more focused link text. Here is a suggestion:
Check out our new guide: <a href="/ai/best-practices">AI best practices for Flutter</a>.|
Visit the preview URL for this PR (updated for commit 1278948): https://flutter-docs-prod--pr12903-feat-ai-best-practices-zmrw6lxu.web.app |
@sfshaza2 What do you think about a banner like this to call out the new docs section? Also happy to reword it if you have any suggestions :D