Skip to content

Conversation

Doublonmousse
Copy link
Collaborator

@Doublonmousse Doublonmousse commented May 20, 2025

Fixes #1258

Now for now I'm blocking/unblocking signals upon startup.

  • I'm not 100% sure if the unsaved indicator is coming from the add_initial_tab and widget flags from this call
  • Not all signal handler are blocked for now

These one can also change the store and are not treated yet

  • doc_background_pattern_color_button
  • doc_background_color_button
  • set_document_layout calling to -> doc_document_layout_row

It also seems to me like we can either change the logic to set the initial values for the document section before the activation or setup of the handlers in setup_doc or change how the SignalHandlerId variables are held to only use them once (we probably don't need to reuse them later).

Seems like the unsaved indicator on startup is a little more common after the refactor on document settings as well

@Doublonmousse Doublonmousse changed the title fix: block signals modified the store upon startup fix: block signals modifying the store upon startup May 23, 2025
Using the sensitivity option for all relevant buttons until the first init including the initial tab are added
@Doublonmousse Doublonmousse force-pushed the fix_1258_unsaved_upon_startup branch from 6de9682 to 5c0a3a1 Compare August 20, 2025 16:36
@Doublonmousse Doublonmousse marked this pull request as ready for review August 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty document created on startup handled by Rnote as modified by default while it should be considered as empty and unmodified by default
1 participant