Skip to content

WIP: [Feature] Setting to enable automatic background color/pattern inversion for each document #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: [Feature] Setting to enable automatic background color/pattern inversion for each document #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions crates/rnote-ui/data/ui/settingspanel.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,21 @@ gets disabled.</property>
</child>
</object>
</child>
<child>
<object class="AdwComboRow" id="general_background_invert_mode_row">
<property name="title" translatable="yes">Invert Background Brightness</property>
<property name="subtitle" translatable="yes">Invert the brightness of the background and pattern colors</property>
<property name="model">
<object class="GtkStringList">
<items>
<item translatable="yes">Disabled</item>
<item translatable="yes">Enabled</item>
<item translatable="yes">Follow system</item>
</items>
</object>
</property>
</object>
</child>
</object>
</child>
<!-- Format Group -->
Expand Down Expand Up @@ -440,18 +455,6 @@ gets disabled.</property>
<property name="subtitle" translatable="yes">Set whether the document origin indicator is shown</property>
</object>
</child>
<child>
<object class="AdwActionRow" id="background_pattern_invert_color_row">
<property name="title" translatable="yes">Invert Color Brightness</property>
<property name="subtitle" translatable="yes">Invert the brightness of the background and pattern colors</property>
<child type="suffix">
<object class="GtkButton" id="background_pattern_invert_color_button">
<property name="valign">center</property>
<property name="label" translatable="yes">Invert</property>
</object>
</child>
</object>
</child>
</object>
</child>
<!-- Button Shortcuts Group -->
Expand Down
53 changes: 17 additions & 36 deletions crates/rnote-ui/src/settingspanel/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ mod imp {
#[template_child]
pub(crate) general_drawing_cursor_picker_menubutton: TemplateChild<MenuButton>,
#[template_child]
pub(crate) general_background_invert_mode_row: TemplateChild<adw::ComboRow>,
#[template_child]
pub(crate) format_predefined_formats_row: TemplateChild<adw::ComboRow>,
#[template_child]
pub(crate) format_save_preset_button: TemplateChild<Button>,
Expand Down Expand Up @@ -109,8 +111,6 @@ mod imp {
#[template_child]
pub(crate) doc_show_origin_indicator_row: TemplateChild<adw::SwitchRow>,
#[template_child]
pub(crate) background_pattern_invert_color_button: TemplateChild<Button>,
#[template_child]
pub(crate) penshortcut_stylus_button_primary_row: TemplateChild<RnPenShortcutRow>,
#[template_child]
pub(crate) penshortcut_stylus_button_secondary_row: TemplateChild<RnPenShortcutRow>,
Expand Down Expand Up @@ -397,6 +397,16 @@ impl RnSettingsPanel {
self.imp().general_inertial_scrolling_row.clone()
}

pub(crate) fn invert_mode(&self) -> u32 {
self.imp().general_background_invert_mode_row.selected()
}

pub(crate) fn set_background_pattern_invert_mode(&self, mode: u32) {
self.imp()
.general_background_invert_mode_row
.set_selected(mode);
}

pub(crate) fn document_layout(&self) -> Layout {
Layout::try_from(self.imp().doc_document_layout_row.get().selected()).unwrap()
}
Expand Down Expand Up @@ -1144,43 +1154,14 @@ impl RnSettingsPanel {
}
));

imp.background_pattern_invert_color_button
imp.general_background_invert_mode_row
.get()
.connect_clicked(clone!(
.connect_selected_item_notify(clone!(
#[weak(rename_to=settings_panel)]
self,
#[weak]
appwindow,
move |_| {
let Some(canvas) = appwindow.active_tab_canvas() else {
return;
};

let mut widget_flags = {
let mut engine = canvas.engine_mut();
engine.document.config.background.color = engine
.document
.config
.background
.color
.to_inverted_brightness_color();
engine.document.config.background.pattern_color = engine
.document
.config
.background
.pattern_color
.to_inverted_brightness_color();
engine.document.config.format.border_color = engine
.document
.config
.format
.border_color
.to_inverted_brightness_color();
engine.background_rendering_regenerate()
};

widget_flags.refresh_ui = true;
widget_flags.store_modified = true;
appwindow.handle_widget_flags(widget_flags, &canvas);
}
move |_| todo!()
));
}

Expand Down