@W-19368406: [MSDK] Local dev instant login (Android)

[JohnsonEricAtSalesforce]

🎸 Ready For Review 🥁

This adds a new activity which may be used for debug app builds only to authenticate a user via test credentials in automated tests. The new activity will finish without any action for app release builds. This is controlled by Salesforce Mobile SDK's existing isDebugBuild property.

This new means of automating authentication for debug testing does not expose production builds to risk and also minimizes access since usernames and passwords are not used. The test credentials JSON provided by Salesforce Mobile SDK's REST Explorer sample app uses refresh tokens which can be remotely expired and cannot be used for privilege elevation beyond the public APIs.

From the shell, the new intent may be started using ADB.

$ adb shell
$ am start -n <App Package Namepace>/com.salesforce.androidsdk.util.test.TestAuthenticationActivity -e creds '<Credentials JSON>'

The "App Package Namespace" is the app's package namespace, which is usually declared in the app module's Gradle script via android { namespace.

The "Credentials JSON" can be obtained by running the existing Salesforce Mobile SDK REST Explorer sample app, logging in and then using the "Dev Menu" "Export Credentials To Clipboard" menu item.

Note that the shell invocation must preserve quotations and other potentially interpreted characters from the shell such that the Credentials JSON is received by the activity without alteration.

The new intent could also be launched by UIAutomator2.

intent.setComponent(ComponentName("<App Package Namespace>", "com.salesforce.androidsdk.util.test.TestAuthenticationActivity"))
intent.putExtra("creds", "<Credentials JSON>")
context.startActivity(intent)

Appium is another means of launching the new intent.

capabilities = {
       "platformName": "Android",
       "deviceName": "Android Emulator",
       "appPackage": "<App Package Namespace>",
       "appActivity": "com.salesforce.androidsdk.util.test.TestAuthenticationActivity",
       "appium:processArguments": {
           "args": ["creds", "<Credentials JSON>"]
       }
   }

[github-actions]

Job Summary for Gradle

Pull Request :: test-android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
SalesforceMobileSDK-Android	libs:SalesforceSDK:lint	8.14.2	✅
SalesforceMobileSDK-Android	libs:SalesforceSDK:assembleAndroidTest	8.14.2	❌
SalesforceMobileSDK-Android	libs:SalesforceSDK:convertCodeCoverage	8.14.2	✅

[github-actions]

Job Summary for Gradle

Pull Request :: test-android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
SalesforceMobileSDK-Android	libs:SalesforceSDK:lint	8.14.2	✅
SalesforceMobileSDK-Android	libs:SalesforceSDK:assembleAndroidTest	8.14.2	❌
SalesforceMobileSDK-Android	libs:SalesforceSDK:convertCodeCoverage	8.14.2	✅

[wmathurin]

What's keeping it from being used in production? Should we check that we are in a debug build in the code?

[JohnsonEricAtSalesforce]

We ought to be able to use the SalesforceSDKManager isDebugBuild check in the activity and simply finish without action for other build types.

[github-actions]

	1 Warning
⚠️	libs/SalesforceSDK/AndroidManifest.xml#L0 - The project references RTL attributes, but does not explicitly enable or disable RTL support with android:supportsRtl in the manifest

Generated by 🚫 Danger

[github-actions]

Job Summary for Gradle

Pull Request :: test-android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
SalesforceMobileSDK-Android	libs:SalesforceSDK:lint	8.14.2	✅
SalesforceMobileSDK-Android	libs:SalesforceSDK:assembleAndroidTest	8.14.2	❌
SalesforceMobileSDK-Android	libs:SalesforceSDK:convertCodeCoverage	8.14.2	✅

[JohnsonEricAtSalesforce]

Note the test failures I've observed are also present on dev. I verified this in an earlier commit here by temporarily disabling them. All tests passed in that case.

[JohnsonEricAtSalesforce]

This subtle change resolves inspector warnings and should be acceptable for tests. I'd used the same style where dynamic background color is now used as well.