Fixes #603: Now use a rolling restart to minimize downtime. #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@indexzero is this going to get merged in? |
kibertoad
requested changes
Jan 5, 2019
Contributor
kibertoad
left a comment
kibertoad
left a comment
There was a problem hiding this comment.
This shouldn't be a default behaviour. Please modify this to be a configuration option.
Author
Why not? It minimizes downtime. |
Contributor
|
@markstos Because it modifies default behaviour that existing production environments might be relying on. Such changes should be opt-in, not opt-out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.