Skip to content

Assign VUIDs on iterationState pool creation #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Assign VUIDs on iterationState pool creation #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/workers/active_scenario.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ func (s *ActiveScenario) Setup() {
s.m.RecordSetupResult(s.scenario.Name, metrics.Result(s.t.Failed()), duration)
}

func (s *ActiveScenario) newIterationState() *iterationState {
func (s *ActiveScenario) newIterationState(id int) *iterationState {
t, teardown := testing.NewTWithOptions(s.scenario.Name,
testing.WithVUID(id),
testing.WithLogger(s.logger),
testing.WithLogrusLogger(s.logrusLogger),
)
Expand Down
2 changes: 1 addition & 1 deletion internal/workers/pool_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func New(maxIterations uint64, activeScenario *ActiveScenario) *PoolManager {
func (m *PoolManager) makeIterationStatePool(numWorkers int) []*iterationState {
statePool := make([]*iterationState, numWorkers)
for i := range numWorkers {
statePool[i] = m.activeScenario.newIterationState()
statePool[i] = m.activeScenario.newIterationState(i)
}

return statePool
Expand Down
7 changes: 7 additions & 0 deletions pkg/f1/testing/t.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type T struct {
require *require.Assertions
Iteration string // iteration number or "setup"
Scenario string
VUID int
teardownStack []func()
failed atomic.Bool
teardownFailed atomic.Bool
Expand Down Expand Up @@ -57,6 +58,12 @@ func WithIteration(iteration string) TOption {
}
}

func WithVUID(id int) TOption {
return func(t *T) {
t.VUID = id
}
}

// NewT returns a new T state
//
// Deprecated: Will be removed in favour of NewTWithOptions
Expand Down