Fix parent typing to use ShallowRef #159
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the typing of the parent property in VueDragAndDropData.
Previously, it was defined as:
However, in practice we are passing a template ref, which in Vue 3 is typed as a ShallowRef.
Problem
When consuming this interface, TypeScript raises errors because the type does not align with how Vue template refs are defined:
Currently, the workaround is to cast ShallowRef to Ref, but this is misleading and hides the actual usage pattern.
Solution
Update the type definition to reflect Vue’s behavior:
This makes the typing consistent with
useTemplateRefand avoids unnecessary type assertions.Impact