-
Notifications
You must be signed in to change notification settings - Fork 199
Add default (mold, array_size) overloads for rvs_normal #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add default (mold, array_size) overloads for rvs_normal #1056
Conversation
|
@jvdp1, Can you have a look. Needs review...! |
jvdp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gururaj1512 . I have some suggestions below.
|
@jvdp1, I've refactored as per your suggestion. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 25.12% 25.13% +0.01%
==========================================
Files 570 570
Lines 234201 234201
Branches 41277 41274 -3
==========================================
+ Hits 58838 58866 +28
+ Misses 175363 175335 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you. LGTM. Could you also update the specs, please? |
|
@jvdp1, Updated the specs...! |
Resolves #963