Skip to content

Conversation

@gururaj1512
Copy link

Resolves #963

  • Add convenience overloads for rvs_normal that accept (mold, array_size) and return standard-normal arrays (loc=0, scale=1) for both real and complex kinds.
  • Add deterministic tests that compare the new (mold, array_size) call with the explicit (loc=0, scale=1, array_size) call to ensure identical behavior.

@gururaj1512
Copy link
Author

@jvdp1, Can you have a look. Needs review...!

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gururaj1512 . I have some suggestions below.

@gururaj1512
Copy link
Author

@jvdp1, I've refactored as per your suggestion.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.13%. Comparing base (fffe0d7) to head (6e2fd8e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   25.12%   25.13%   +0.01%     
==========================================
  Files         570      570              
  Lines      234201   234201              
  Branches    41277    41274       -3     
==========================================
+ Hits        58838    58866      +28     
+ Misses     175363   175335      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvdp1
Copy link
Member

jvdp1 commented Nov 15, 2025

@jvdp1, I've refactored as per your suggestion.

Thank you. LGTM. Could you also update the specs, please?

@gururaj1512
Copy link
Author

@jvdp1, Updated the specs...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make loc and scale arguments of rvs_normal optional when returning an array

2 participants