-
Notifications
You must be signed in to change notification settings - Fork 205
fix Issue #1063 #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix Issue #1063 #1064
Conversation
|
I am not sure this will be a good fix - some of those source files may now appear as duplicates |
|
Provisionally it works, at least it picked up from where it broke and now continuing for a while. I will wait until it finishes, hopefully, and confirm. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
=======================================
Coverage 68.93% 68.93%
=======================================
Files 390 390
Lines 12650 12650
Branches 1377 1377
=======================================
Hits 8720 8720
Misses 3930 3930 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@perazz The build completed successfully. Thank you! |
jvdp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @perazz
jalvesz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @perazz thanks for this fix!!
The LAPACK library fails to link with an undefined symbol error:
Undefined symbols for architecture ppc:
"___stdlib_string_type_MOD_new_string", referenced from:
___stdlib_io_MOD_get_line_string in stdlib_io.f90.o
When the LAPACK module was modularized in #1033 (commit 80a8164), the stdlib_string_type_constructor.fypp submodule was not included in src/lapack/CMakeLists.txt.
The dependency chain is:
The LAPACK library included the first two but was missing the third, resulting in an undefined symbol at link time.
cc: @barracuda156 @jvdp1